Skip to content

Revise fetching latest patch version of python #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

stefanbotez
Copy link
Contributor

Description of changes:

  • In the buildspec files for OS compatibility tests only the major.minor version of python is specified. Then, in the Dockerfile the latest patch version is fetched.
    The problem with this is that it can happen that there will be a patch version not released yet, but there is a release candidate for that (at the moment it is for Python 3.8.7). This will cause an error.
    Modified so that every patch version is tried from the latest one to the earliest one until a valid one is found.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@krk krk self-requested a review January 7, 2021 14:20
Copy link
Contributor

@krk krk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlzogh carlzogh merged commit 21e67e5 into aws:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants